search

javierriveracastro / betteroll-swade

A Better Rolls port for SWADE
GNU General Public License v3.0
16 stars 32 forks source link

[Suggestion] Change of the Apply Damage icon? #152

Closed CyrilRonseaux closed 3 years ago

CyrilRonseaux commented 3 years ago

I find it confusing that the Apply Damage icon looks like the Raise icon. Could go with a blood drop or so? image

javierriveracastro commented 3 years ago

It is a font awesome icon. You can check here the ones that are available in foundry:

https://fontawesome.com/icons?d=gallery&p=2&m=free

if you can find one more clear I'll love to add it. The other option is using a svg file, but that could be more complex (I need to check to code to be sure).

Razortide commented 3 years ago

Bahai, Heartbeat, Skull?

CyrilRonseaux commented 3 years ago

I was thinking "tint" image

But I like bahai the best. Heartbeat is good too. Skull sounds a bit final :D

SalieriC commented 3 years ago

amazon-pay as in "you'll pay for that!" XD I think tint is the best option here as it would be consistent with the damage result icons. Bahai, Heartbeat and Skull do not strike my fancy.

CyrilRonseaux commented 3 years ago

I just realized the tint icon is already used for actual wounds. image

Maybe some some generic icon, like angle-double-down image

or sign-in-alt image

SalieriC commented 3 years ago

That's what I was saying... I honestly think a single checkmark would be the best option here, as it signalises "apply" the most.

javierriveracastro commented 3 years ago

This has not been exactly helpful... :). Now either a roll a dice or make a setting for the apply damage icon XDDDD

Seriously, I tend to agree with SalieriC that a checkmark is the best known "apply" icon, but it usually used with something else. Maybe both the tint and a check is more clear.

CyrilRonseaux commented 3 years ago

Single check mark ok for me as long as it's an icon which doesn't not mean "success" or "raise" already (or "shaken" or "wound"). Something which is dedicated to "do it" and has no other meaning in the module.

javierriveracastro commented 3 years ago

That's my try:

imaxe

Feel free to reopen the bug if you have a better idea.

SalieriC commented 3 years ago

Can I persuade you to allign the results? This picture is making me uncomfortable. XD

javierriveracastro commented 3 years ago

Sure, but please open a different bug.

You know I hate CSS bugs, I'll find something nasty on Spices in retaliation.

CyrilRonseaux commented 3 years ago

This solution is clear, I like it! thank you very much!