javierriveracastro / betteroll-swade

A Better Rolls port for SWADE
GNU General Public License v3.0
16 stars 32 forks source link

Factions select don't seem to be working properly #540

Closed grendel111111 closed 1 year ago

grendel111111 commented 1 year ago

When you try to add faction 'same' it works on all targets no matter their disposition. I used this as a test when I couldn't make it work in other world actions:


"name":"faction",
"button_name":"faction ",
"extra_text":"<p style='color: green;' > Your target is the same faction.</p>",
"selector_type":"faction","selector_value":"same",
"defaultChecked":"on",
"group":"faction"}```

All 3 targets it was used on showed "Your target is the same faction."  even though the user was friendly,  first target  was hostile, the second neutral and the last friendly. (It should have only worked on friendly).
![image](https://user-images.githubusercontent.com/80164119/204009758-9ee946a9-5ba6-47b5-8159-18bdf86097e3.png)
javierriveracastro commented 1 year ago

Ouch, that was a regression probably from the v8 to v9 update!!

It should work again now (in git)