search

javierriveracastro / betteroll-swade

A Better Rolls port for SWADE
GNU General Public License v3.0
15 stars 31 forks source link

actor_has_effect has got messed up between 3.19 and 3.20. #575

Closed grendel111111 closed 1 year ago

grendel111111 commented 1 year ago

image

image The first picture is from 3.2/3.21 The second picture is from 3.19 (With no other changes)

In one of the changes from 3.19 to 3.20 the "actor_has_effect" condition seems to have got a bit messed up (target_has_effect is still fine). The actor has the effect Fear and it used to bring up an option to roll to resist the fear effect.

This was done by this action: {"id":"9ResistingFear", "name":"Resisting Fear", "button_name":"Resisting Fear", "runSkillMacro":"FearResults", "and_selector":[ {"selector_type":"attribute", "selector_value":"Spirit"}, {"selector_type":"actor_has_effect", "selector_value":"Fear"}, {"not_selector":[ {"selector_type":"item_type", "selector_value":"weapon"}]}], "group":"Resisting Fear"}

javierriveracastro commented 1 year ago

Ummm... nothing was touched there since September.

imaxe

Something else must be going on.

javierriveracastro commented 1 year ago

Could it be that you have two actions with the same id?

grendel111111 commented 1 year ago

Update. After doing a lot of tests it is a problem with Token Action HUD. If you use it to call a roll on an unlinked actor it runs the roll from the actor on the side bar. So if you have an active effect on the token, but not on the actor on the sidebar it doesn't register the effect (It looks at the actor in the side bar to decide what effect etc are on the actor not the token). Like wise if there is an item on the character in the side bar but not the token it treats it as having the effect.

javierriveracastro commented 1 year ago

Then this is probably a TAH issue. As it is transitioning from a all system supported architecture to each system is its own module one I'm not sure if it makes sense to look into it or if it's better to just wat for a new release.

javierriveracastro commented 1 year ago

I will close this until TAH future is somewhat clear.