search

javierriveracastro / betteroll-swade

A Better Rolls port for SWADE
GNU General Public License v3.0
15 stars 31 forks source link

Bullet consumption issue #604

Closed WyntherKnight closed 12 months ago

WyntherKnight commented 12 months ago

Toggling the "Subtract ammo" causes the weapon to consume a number of shots equal to what is written on the ROF of the weapon (if ROF is 4, then 4 shots are used). Toggling it off actually consumes a number of ammo as written in the rules (if ROF is 4, then 20 shots are used). Shouldn't this be the other way around?

image

javierriveracastro commented 12 months ago

Ummm... are you using SWIM ammo management?

WyntherKnight commented 12 months ago

Yes, I use SWIMM, but I don't see any ammo mangement in for PCs (only for NPC) so I disabled SWIMM. Now when "subtract ammo" is toggled, It still only consumes 4 shots (for an ROF of 4) and disabling it does not consume any shots.

WyntherKnight commented 12 months ago

I see, looks like SWIMM is able to use the rules of ammo consumption correctly, but BRSW doesn't.

javierriveracastro commented 12 months ago

The truth is that BRSW doesn't do ammo management. It delegates it either to the system or SWIM. But let me check if I'm passing something incorrectly to system.

WyntherKnight commented 12 months ago

Thanks. We could have sworn that BRSW was the one handling the ammo consumption.

javierriveracastro commented 12 months ago

At the end it was my fault. I was passing the incorrect number of shots to system.