javierriveracastro / betteroll-swade

A Better Rolls port for SWADE
GNU General Public License v3.0
15 stars 31 forks source link

Sort don't sort well #618

Closed brunocalado closed 10 months ago

brunocalado commented 10 months ago

The IDs sort feature is not working well. It's working in reverse.

image

  {
    id: "CH01PP",
    name: "+1 PP",
    button_name: "+1",
    "shotsUsed": "+1",
    selector_type: "item_type",
    selector_value: "power",
    group: "Power Points"
  },
  {
    id: "CH02PP",
    name: "+2 PP",
    button_name: "+2",
    "shotsUsed": "+2",
    selector_type: "item_type",
    selector_value: "power",
    group: "Power Points"
  },
  {
    id: "CH03PP",
    name: "+3 PP",
    button_name: "+3",
    "shotsUsed": "+3",
    selector_type: "item_type",
    selector_value: "power",
    group: "Power Points"
  },
  {
    id: "CH04PP",
    name: "+4 PP",
    button_name: "+4",
    "shotsUsed": "+4",
    selector_type: "item_type",
    selector_value: "power",
    group: "Power Points"
  },
  {
    id: "CH05PP",
    name: "+5 PP",
    button_name: "+5",
    "shotsUsed": "+5",
    selector_type: "item_type",
    selector_value: "power",
    group: "Power Points"
  },
  {
    id: "CH06PP",
    name: "+6 PP",
    button_name: "+6",
    "shotsUsed": "+6",
    selector_type: "item_type",
    selector_value: "power",
    group: "Power Points"
  },
  {
    id: "CH07PP",
    name: "+7 PP",
    button_name: "+7",
    "shotsUsed": "+7",
    selector_type: "item_type",
    selector_value: "power",
    group: "Power Points"
  },
  {
    id: "CH08PP",
    name: "+8 PP",
    button_name: "+8",
    "shotsUsed": "+8",
    selector_type: "item_type",
    selector_value: "power",
    group: "Power Points"
  },
  {
    id: "CH09PP",
    name: "+9 PP",
    button_name: "+9",
    "shotsUsed": "+9",
    selector_type: "item_type",
    selector_value: "power",
    group: "Power Points"
  },
javierriveracastro commented 10 months ago

I can't reproduce this... how are you adding the actions?

BTW, I'd add that power point actions to the module if you don't mind....

javierriveracastro commented 10 months ago

Now that I'm writing the next version changelog I see that I have already fixed this before. No surprise it is working for me and not for you. Closing it, feel free to open it again if it doesn't work in 3.42

brunocalado commented 10 months ago

It's working well on 342 thank you