search

javierriveracastro / betteroll-swade

A Better Rolls port for SWADE
GNU General Public License v3.0
15 stars 31 forks source link

Fixing the scope on .flex #678

Closed ddbrown30 closed 4 months ago

ddbrown30 commented 4 months ago

As per the issue I opened, here is the fix for just .flex which fixes the issue I was seeing in Item Piles. I the action selection, trait rolls, and damage rolls and they all appear to be correct but I would suggest you have a quick look yourself before merging the PR to main.

I suck at CSS so it's entirely possible I've done something incorrectly here, but I'm fairly sure that it at least doesn't break anything.

javierriveracastro commented 4 months ago

Yes, you did something incorrect here. brsw-tw-styles.css is an auto-generated file. Your changes will be overwritten as soon as i open the file in my IDE.

The manual styles are in brsw-styles.css.

I'm using tailwind as I'm probably ever worse than you at CSS (https://tailwindcss.com/).

I don't know if it is possible to easily change the scope of tailwind generated CSS, I'd check. But the file that should be changed is likely tailwind.config.js

BTW, Sourcery has been really a rude AI here XDDDD.

javierriveracastro commented 4 months ago

Preliminary testing shows that this can be done using the TailWind prefix option.

But I'll need to go template by template changing each style name by hand, what can be fun giving how verbose TW is.

Check the second answer, the accepted one doesn't work:

https://stackoverflow.com/questions/63761312/how-to-scope-tailwind-css

Anyway, closing it, as this PR does nothing.