If you look at the commit history on the PR, I actually tried two different versions but I prefer the second. How I've set this up is that we check for any effect named "Deflection" but we exclude anything named "Deflection (melee)" or "Deflection (ranged)." This allows support for anyone who is using a Deflection effect (even if it wasn't added by SUCC/SWIM) to be able to take advantage of the Deflection functionality in BR2.
The previous version had me directly checking for "Deflection (both)" but I really didn't like that name and it also made it a requirement that everyone had to use that naming convention.
If you look at the commit history on the PR, I actually tried two different versions but I prefer the second. How I've set this up is that we check for any effect named "Deflection" but we exclude anything named "Deflection (melee)" or "Deflection (ranged)." This allows support for anyone who is using a Deflection effect (even if it wasn't added by SUCC/SWIM) to be able to take advantage of the Deflection functionality in BR2.
The previous version had me directly checking for "Deflection (both)" but I really didn't like that name and it also made it a requirement that everyone had to use that naming convention.