javierriveracastro / betteroll-swade

A Better Rolls port for SWADE
GNU General Public License v3.0
15 stars 31 forks source link

Modifier for hindrances is calculated twice #717

Closed peterprokurist closed 1 month ago

peterprokurist commented 1 month ago

If a Hindrance has an automatic effect, this will be shown (and calculated) twice. Here is the example of “Mean”, which gives -1 to “Persuasion”:

image

image

image

ddbrown30 commented 1 month ago

You need to disable the effect on the actor.

peterprokurist commented 1 month ago

thaaaaank you! :-)

ddbrown30 commented 1 month ago

No prob. :)

javierriveracastro commented 1 month ago

Or disable the action in BR configuration.

I'll try to see if we can auto-disable it.

javierriveracastro commented 1 month ago

Added a check to disable the action if the core rules are enabled. It is not perfect, as the active effect can be there and the core rules disabled, but it should avoid this problem 90% of the time.

It can also be extended to other problematic items in the future.