javiersantos / MaterialStyledDialogs

A library that shows a beautiful and customizable Material-based dialog with header. API 14+ required.
Apache License 2.0
1.17k stars 155 forks source link

Slide Up Animations not working correctly #41

Closed mustafa-demir closed 7 years ago

mustafa-demir commented 7 years ago

There are some wrong code in slide up animation related xml files. This causes wrong behaviour. If you watch carefully slide up animations you will see.

Currently: md_styled_slide_up_fast.xml :

<?xml version="1.0" encoding="utf-8"?>
<set xmlns:android="http://schemas.android.com/apk/res/android" >
    <translate
        android:duration="@android:integer/config_shortAnimTime"
        android:fromYDelta="100%"
        android:interpolator="@android:anim/accelerate_interpolator"
        android:toXDelta="0" />
</set>

But it must be like this :

<?xml version="1.0" encoding="utf-8"?>
<set xmlns:android="http://schemas.android.com/apk/res/android">
    <translate
        android:duration="@android:integer/config_shortAnimTime"
        android:fromYDelta="100%p"
        android:interpolator="@android:anim/accelerate_interpolator"
        android:toYDelta="0%p"/>
</set>

Those small mistakes are in slide up animation related xml files.(all three)

Nothing big, it is just a small mistake.

Thanks for the library.