search

javiersantos / WhatsAppBetaUpdater

An app to update WhatsApp to the latest beta version available on Android. Based on Material Design.
GNU General Public License v3.0
192 stars 57 forks source link

enabled title to wrap #23

Closed thoemmi closed 8 years ago

thoemmi commented 8 years ago

The title Beta Updater for WhatsApp is quite long, so the text is clipped: image This PR changes the layout so wrapping is possible: image

I searched the internet for how to wrap the title of a CollapsingToolbarLayout. Unfortunately, that's not possible. Instead you have to make the CollapsingToolbarLayout's title transparent and add another TextView.

I'm not an Android developer. In fact, I just downloaded Android Studio just to fix this (the cutoff title always annoyed me). So there might be a better to achieve this, and there might be layout issue when changing the display dimensions. Anyway, I wouldn't be offended if you'd reject this PR :wink:

I really appreciate your project.

kerembeyazit commented 8 years ago

+1 or just decrease the font size.

javiersantos commented 8 years ago

Thanks for your PR @thoemmi. You are right, CoordinatorToolbarLayout doesn't allow multiline for the title, but making it transparent and adding another TextView solves this.

I am going to merge this PR and make a little change to the style to support API < 17.

@cevem I think it is the best way to achieve this. Decreasing the font size to the title doesn't ensure that devices with smaller screen show the full title.