javinizer / Javinizer

(NSFW) Organize your local Japanese Adult Video (JAV) library
MIT License
606 stars 63 forks source link

jvthumb is not updating #358

Closed obiwone2000 closed 1 year ago

obiwone2000 commented 1 year ago

Expected Behavior

Sorted Actress name and pic would be saved to the list for future use

Current Behavior

The Actress info is not saving. Believe this is due to R18 becomes unavailable

Steps to Reproduce (for bugs)

Your Environment

obiwone2000 commented 1 year ago

Raised in the discord chat, hope this is getting on to the list of issues to be fixed

seeyabye commented 1 year ago

Should be usable now. Check the latest version.

obiwone2000 commented 1 year ago

It is starting to get new entries, but I don't believe the entries are correct however. Example below

"Wakuimito","","Wakuimito","和久井美兎","wakui_mito.jpg", "Ashinahonoka","","Ashinahonoka","芦名ほのか","asina_honoka.jpg", "Takahatachihana","","Takahatachihana","高畑ちはな","takahata_tihana.jpg", "Hafu Yuria","Hafu","Yuria","葉風ゆりあ","hakaze_yuria.jpg", "Kashiwagi Konatsu","Kashiwagi","Konatsu","柏木こなつ","kasiwagi_konatu.jpg", "Kitayamayū","","Kitayamayū","北山憂","kitayama_yuu.jpg", "Otsu Alice","Otsu","Alice","乙アリス","otu_arisu.jpg", "Aratārina","","Aratārina","新ありな","arata_arina.jpg", "Minase Akari","Minase","Akari","皆瀬あかり","minase_akari.jpg", "Iorihinano","","Iorihinano","伊織ひなの","iori_hinano.jpg", "Yuzuriha Karen","Yuzuriha","Karen","楪カレン","yuzuriha_karen.jpg", "Mai Tsubasa","Mai","Tsubasa","つばさ舞","tubasa_mai.jpg", "Unpai","","Unpai","うんぱい","unpai.jpg", "Amamiya Hanan","Amamiya","Hanan","天宮花南","amamiya_kanan.jpg", "Kamikirei","","Kamikirei","神木麗","kamiki_rei.jpg",

seeyabye commented 1 year ago

What version and scraper are you currently using?

obiwone2000 commented 1 year ago

Sorry, How do I check? I only updated the GUI to 2.5.13

seeyabye commented 1 year ago

If you can share your settings, it would be better.

From the look for the jvThumbs.csv you shared, it looks fine except for names where the last name and first name are merged. This is highly dependent on the source you are scraping from. I will need to know which scraper you are using before I further debug it.

obiwone2000 commented 1 year ago

Attached my settings file, is that what you need?

jvSettings.txt

Believe the data is getting from r18dev and current scrapper is below, also the full path for the thumbnail is missing:

function Get-R18DevActress { [CmdletBinding()] param ( [Parameter(Mandatory = $true, Position = 0, ValueFromPipeline = $true)] [Object]$Webrequest,

    [Parameter()]
    [String]$Url
)

process {

    $movieActressObject = @()

    if ($Webrequest.actresses) {
        for ($x = 0; $x -lt $Webrequest.actresses.count; $x++) {
            if (!$Webrequest.actresses[$x].image_url.StartsWith('http')) {
                $ThumbUrl = 'https://pics.dmm.co.jp/mono/actjpgs/' + $Webrequest.actresses[$x].image_url
            } else {
                $ThumbUrl = $Webrequest.actresses[$x].image_url
            }

            $movieActressObject += [PSCustomObject]@{
                LastName     = ($Webrequest.actresses[$x].name_romaji -split ' ')[1] -replace '\\', ''
                FirstName    = ($Webrequest.actresses[$x].name_romaji -split ' ')[0] -replace '\\', ''
                JapaneseName = $Webrequest.actresses[$x].name_kanji -replace '(.*)', '' -replace '&', '&'
                ThumbUrl     = $ThumbUrl
            }
        }
    }

    if ($movieActressObject.count -lt 1) {
        $movieActressObject = $null
    }

    Write-Output $movieActressObject
}

}

obiwone2000 commented 1 year ago

{ "throttlelimit": 3, "location.input": "X:\", "location.output": "X:\", "location.thumbcsv": "", "location.genrecsv": "", "location.uncensorcsv": "", "location.historycsv": "", "location.tagcsv": "", "location.log": "", "scraper.movie.aventertainment": false, "scraper.movie.aventertainmentja": true, "scraper.movie.r18dev": true, "scraper.movie.dmm": false, "scraper.movie.dmmja": true, "scraper.movie.jav321ja": true, "scraper.movie.javbus": false, "scraper.movie.javbusja": true, "scraper.movie.javbuszh": false, "scraper.movie.javdb": false, "scraper.movie.javdbzh": false, "scraper.movie.javlibrary": false, "scraper.movie.javlibraryja": true, "scraper.movie.javlibraryzh": false, "scraper.movie.mgstageja": true, "scraper.movie.tokyohot": false, "scraper.movie.tokyohotja": true, "scraper.movie.tokyohotzh": false, "scraper.option.dmm.scrapeactress": true, "scraper.option.idpreference": "id", "scraper.option.addmaleactors": false, "match.minimumfilesize": 0, "match.includedfileextension": [ ".asf", ".avi", ".flv", ".m4v", ".mkv", ".mp4", ".mov", ".rmvb", ".wmv" ], "match.excludedfilestring": [ "^.-trailer", "^.-5\." ], "match.regex": false, "match.regex.string": "([a-zA-Z|tT28]+-\d+[zZ]?[eE]?)(?:-pt)?(\d{1,2})?", "match.regex.idmatch": 1, "match.regex.ptmatch": 2, "sort.movetofolder": true, "sort.renamefile": true, "sort.renamefolderinplace": false, "sort.maxtitlelength": 40, "sort.movesubtitles": false, "sort.create.nfo": true, "sort.create.nfoperfile": true, "sort.download.actressimg": true, "sort.download.thumbimg": true, "sort.download.posterimg": true, "sort.download.screenshotimg": true, "sort.download.trailervid": false, "sort.download.timeoutduration": 100000, "sort.format.groupactress": false, "sort.format.delimiter": ", ", "sort.format.file": "", "sort.format.folder": " - - (<YEAR>)", "sort.format.outputfolder": "", "sort.format.posterimg": "folder", "sort.format.thumbimg": "fanart", "sort.format.trailervid": "<ID>-trailer", "sort.format.nfo": "<ID>", "sort.format.screenshotimg": "fanart", "sort.format.screenshotimg.padding": 1, "sort.format.screenshotfolder": "extrafanart", "sort.format.actressimgfolder": ".actors", "sort.metadata.nfo.addaliases": false, "sort.metadata.nfo.mediainfo": true, "sort.metadata.nfo.addgenericrole": true, "sort.metadata.nfo.altnamerole": false, "sort.metadata.nfo.translate": false, "sort.metadata.nfo.translate.module": "googletrans", "sort.metadata.nfo.translate.field": "description", "sort.metadata.nfo.translate.language": "en", "sort.metadata.nfo.translate.deeplapikey": "", "sort.metadata.nfo.translate.keeporiginaldescription": true, "sort.metadata.nfo.displayname": "[<ID>] <TITLE>", "sort.metadata.nfo.firstnameorder": false, "sort.metadata.nfo.actresslanguageja": true, "sort.metadata.nfo.unknownactress": true, "sort.metadata.nfo.originalpath": false, "sort.metadata.nfo.actressastag": false, "sort.metadata.nfo.preferactressalias": true, "sort.metadata.nfo.format.tag": "<SET>", "sort.metadata.nfo.format.tagline": "", "sort.metadata.nfo.format.credits": [], "sort.metadata.thumbcsv": true, "sort.metadata.thumbcsv.autoadd": true, "sort.metadata.thumbcsv.convertalias": true, "sort.metadata.genrecsv": true, "sort.metadata.genrecsv.autoadd": true, "sort.metadata.tagcsv": true, "sort.metadata.tagcsv.autoadd": true, "sort.metadata.genre.ignore": [ "^Featured Actress", "^Hi-Def", ".</em>sale.<em>", ".</em>mosaic.*" ], "sort.metadata.requiredfield": [ "id", "coverurl", "genre", "maker", "releaseDate", "title" ], "sort.metadata.priority.actress": [ "DmmJa", "Jav321Ja", "JavbusJa", "JavlibraryJa", "MGStageJa", "TokyoHotJa", "AVEntertainmentJa" ], "sort.metadata.priority.alternatetitle": [ "DmmJa", "Jav321Ja", "JavbusJa", "JavlibraryJa", "MGStageJa", "TokyoHotJa", "AVEntertainmentJa" ], "sort.metadata.priority.coverurl": [ "DmmJa", "JavlibraryJa", "JavbusJa", "Jav321Ja", "MGStageJa", "TokyoHotJa", "AVEntertainmentJa" ], "sort.metadata.priority.description": [ "DmmJa", "Jav321Ja", "JavbusJa", "JavlibraryJa", "MGStageJa", "TokyoHotJa", "AVEntertainmentJa" ], "sort.metadata.priority.director": [ "DmmJa", "Jav321Ja", "JavbusJa", "JavlibraryJa", "MGStageJa", "TokyoHotJa", "AVEntertainmentJa" ], "sort.metadata.priority.genre": [ "DmmJa", "Jav321Ja", "JavbusJa", "JavlibraryJa", "MGStageJa", "TokyoHotJa", "AVEntertainmentJa" ], "sort.metadata.priority.id": [ "DmmJa", "Jav321Ja", "JavbusJa", "JavlibraryJa", "MGStageJa", "TokyoHotJa", "AVEntertainmentJa" ], "sort.metadata.priority.contentid": [ "DmmJa", "Jav321Ja", "JavbusJa", "JavlibraryJa", "MGStageJa", "TokyoHotJa", "AVEntertainmentJa" ], "sort.metadata.priority.label": [ "DmmJa", "Jav321Ja", "JavbusJa", "JavlibraryJa", "MGStageJa", "TokyoHotJa", "AVEntertainmentJa" ], "sort.metadata.priority.maker": [ "DmmJa", "Jav321Ja", "JavbusJa", "JavlibraryJa", "MGStageJa", "TokyoHotJa", "AVEntertainmentJa" ], "sort.metadata.priority.releasedate": [ "DmmJa", "Jav321Ja", "JavbusJa", "JavlibraryJa", "MGStageJa", "TokyoHotJa", "AVEntertainmentJa" ], "sort.metadata.priority.rating": [ "DmmJa", "Jav321Ja", "JavbusJa", "JavlibraryJa", "MGStageJa", "TokyoHotJa", "AVEntertainmentJa" ], "sort.metadata.priority.runtime": [ "DmmJa", "Jav321Ja", "JavbusJa", "JavlibraryJa", "MGStageJa", "TokyoHotJa", "AVEntertainmentJa" ], "sort.metadata.priority.series": [ "DmmJa", "Jav321Ja", "JavbusJa", "JavlibraryJa", "MGStageJa", "TokyoHotJa", "AVEntertainmentJa" ], "sort.metadata.priority.screenshoturl": [ "DmmJa", "Jav321Ja", "JavbusJa", "JavlibraryJa", "MGStageJa", "TokyoHotJa", "AVEntertainmentJa" ], "sort.metadata.priority.title": [ "DmmJa", "Jav321Ja", "JavbusJa", "JavlibraryJa", "MGStageJa", "TokyoHotJa", "AVEntertainmentJa" ], "sort.metadata.priority.trailerurl": [ "DmmJa", "Jav321Ja", "JavbusJa", "JavlibraryJa", "MGStageJa", "TokyoHotJa", "AVEntertainmentJa" ], "emby.url": "<a href="http://192.168.0.1:8096">http://192.168.0.1:8096</a>", "emby.apikey": "", "javlibrary.baseurl": "<a href="http://www.javlibrary.com">http://www.javlibrary.com</a>", "javlibrary.browser.useragent": "", "javlibrary.cookie.cf_chl_2": "", "javlibrary.cookie.cf_chl_prog": "", "javlibrary.cookie.cf_clearance": "", "javlibrary.cookie.session": "", "javlibrary.cookie.userid": "", "javdb.cookie.session": "", "proxy.enabled": false, "proxy.host": "", "proxy.username": "", "proxy.password": "", "web.favorites.genre": [], "web.favorites.tag": [], "web.sort.recurse": false, "web.sort.strict": false, "web.sort.interactive": true, "web.sort.update": false, "web.sort.force": false, "web.sort.preview": false, "web.sort.recursedepth": 10, "web.sort.confirm": false, "web.sort.manualsearch.aventertainment": false, "web.sort.manualsearch.aventertainmentja": true, "web.sort.manualsearch.dmm": false, "web.sort.manualsearch.dmmja": true, "web.sort.manualsearch.jav321ja": true, "web.sort.manualsearch.javbus": false, "web.sort.manualsearch.javbusja": true, "web.sort.manualsearch.javbuszh": false, "web.sort.manualsearch.javdb": false, "web.sort.manualsearch.javdbzh": false, "web.sort.manualsearch.javlibrary": false, "web.sort.manualsearch.javlibraryja": true, "web.sort.manualsearch.javlibraryzh": false, "web.sort.manualsearch.mgstageja": true, "web.sort.manualsearch.r18dev": true, "web.sort.manualsearch.tokyohot": true, "web.sort.manualsearch.tokyohotja": true, "web.sort.manualsearch.tokyohotzh": true, "web.theme": "dark", "admin.log": true, "admin.log.level": "", "admin.updates.check": true }</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/seeyabye"><img src="https://avatars.githubusercontent.com/u/36906720?v=4" />seeyabye</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>It's not scraping from R18Dev at the moment. You need to include R18Dev in your <code>sort.metadata.priority</code> section</p> <p>Seems like getting a thumbnail from DmmJa doesn't work right now, will need to take a look at that. R18Dev should be working though.</p> <pre><code class="language-json">... "sort.metadata.priority.actress": [ "R18Dev", "DmmJa", "Jav321Ja", "JavbusJa", "JavlibraryJa", "MGStageJa", "TokyoHotJa", "AVEntertainmentJa" ], ...</code></pre> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/obiwone2000"><img src="https://avatars.githubusercontent.com/u/96230480?v=4" />obiwone2000</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Added R18Dev and tried. Still the same. Name error, missing thumbnail path</p> <p>I have also updated to 2.5.15</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/seeyabye"><img src="https://avatars.githubusercontent.com/u/36906720?v=4" />seeyabye</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Could you share the video code?</p> <p>Also, what do you get when you use the following in powershell?</p> <pre><code class="language-pwsh">Get-R18DevData -Url <url_link_to_one_of_r18dev_video_page></code></pre> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/obiwone2000"><img src="https://avatars.githubusercontent.com/u/96230480?v=4" />obiwone2000</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Stars-734 I see the path for thumbnail using powershell but name is still wrong. I am using GUI though previously.</p> <p>Get-R18DevData -Url <a href="https://r18.dev/videos/vod/movies/detail/-/id=1stars734r/">https://r18.dev/videos/vod/movies/detail/-/id=1stars734r/</a></p> <p>Source : r18dev Url : <a href="https://r18.dev/videos/vod/movies/detail/-/id=1stars734r/">https://r18.dev/videos/vod/movies/detail/-/id=1stars734r/</a> ContentId : 1stars734r Id : STARS734 Title : A Subordinate With Too Much Style Is Turned Into A Meat Slave By Blackmailing Him. The Lingerie Training Of The Power Harassment Boss In The Company! Rei Kamiki Description : ReleaseDate : 2023-04-13 ReleaseYear : 2023 Runtime : 140 Director : Zaku Arai Maker : SOD Create Label : SOD star Series : Actress : @{LastName=; FirstName=Kamikirei; JapaneseName=神木麗; ThumbUrl=<a href="https://pics.dmm.co.jp/mono/actjpgs/kamiki_rei.jpg">https://pics.dmm.co.jp/mono/actjpgs/kamiki_rei.jpg</a>} Genre : {Embarrassment, Shame, Office Lady, Big Tits…} CoverUrl : <a href="https://pics.dmm.co.jp/mono/movie/1stars734r/1stars734rpl.jp">https://pics.dmm.co.jp/mono/movie/1stars734r/1stars734rpl.jp</a> g ScreenshotUrl : TrailerUrl : <a href="https://cc3001.dmm.co.jp/litevideo/freepv/1/1st/1stars734/1s">https://cc3001.dmm.co.jp/litevideo/freepv/1/1st/1stars734/1s</a> tars734_mhb_w.mp4</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/seeyabye"><img src="https://avatars.githubusercontent.com/u/36906720?v=4" />seeyabye</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>The thumbnail path looks correct from the output. Are you doing a fresh sort? It should output the right thumbnail url to jvThumbs.csv</p> <p>As for the name, it looks correct from r18.dev's data. In fact on r18, there was no information on which is the FirstName and which is the LastName. It's just Romaji=Kamikirei</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/obiwone2000"><img src="https://avatars.githubusercontent.com/u/96230480?v=4" />obiwone2000</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Still not getting the path for the thumbnail, just the file name is showing. Is the GUI getting different information?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/seeyabye"><img src="https://avatars.githubusercontent.com/u/36906720?v=4" />seeyabye</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>Have you tried the latest version? 2.5.17?</p> <p>The GUI just calls the CLI version of Javinizer for most of the operation, so the results should be the same</p> <p>I ran with the mostly default settings, and I had no issue getting jvThumbs.csv to update with the correct thumbnail.</p> <p><img src="https://github.com/javinizer/Javinizer/assets/36906720/74f2d884-fc3b-4541-8b05-5ef864858957" alt="image" /></p> <p>Unless I am misunderstanding something, but at this point I am still confused what is the issue.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/obiwone2000"><img src="https://avatars.githubusercontent.com/u/96230480?v=4" />obiwone2000</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>After updating to 2.5.17 and deleting the existing entry in jvthumb. its getting the thumbs path. I guess the name is r18 bug instead. In terms of manual amendment, even after updating in GUI for the name, it still won't store in jvthumb. I assume the save happened at point of sorting and not at the point of saving the video. Either way, thanks for sorting the thumb path out. Appreciate all your help on this.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/seeyabye"><img src="https://avatars.githubusercontent.com/u/36906720?v=4" />seeyabye</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <p>That is correct, by design it seems that jvThumbs is only updated with new entries. Existing entries will not be updated, so you definitely need to delete the entry to have it corrected. </p> <p>From the code it seems like you can use <code>-UpdateThumbs</code> to do an update, but that's broken right now and I haven't looked into fixing it yet.</p> <p>And yes, the naming is directly taken from r18.dev, and unfortunately it's not splitting correctly. Your only option is to choose aggregators that has the naming correct, or use an alias perhaps.</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>