search

javinizer / Javinizer

(NSFW) Organize your local Japanese Adult Video (JAV) library
MIT License
608 stars 63 forks source link

Can't move video if download of image fails #373

Closed ghost closed 1 year ago

ghost commented 1 year ago

Expected Behavior

Video file to move even if can't download all images

Current Behavior

Video does not move to the sort folder if for example the actress image download fails

Steps to Reproduce (for bugs)

I think this is fairly explanatory but..

  1. Start sorting your files. I'm using the GUI.
  2. Press complete sort for this movie.
  3. NFO and images gets downloaded but because some of the actor thumb urls are broken, and does not download, it stops the movie from being sorted to the sort folder.

Your Environment

Additional info:

I've noticed that this can be sort of bypassed if I just remember to scroll down, click view r18dev data and then press "Replace" for the "Actress"-field. Which is very strange behaviour in general because I'm only using R18dev for scraping anyway.

ghost commented 1 year ago

Actually I think the actress fetch might be broken too in GUI.. For every movie it seems to just want to put Kawai Asuna and few other names in japanese

seeyabye commented 1 year ago

Could you give me a video code where this fails? It would speed up my process for debugging.

ghost commented 1 year ago

Could you give me a video code where this fails? It would speed up my process for debugging.

Sure. ABP-755 (This one does have Kawai Asuna) kuva Image is related as this is how it ends up fetching the data even though it should just be Kawai Asuna alone in that one if I remember right.

I went through all of my library to see is there any others with similar issue and could not find any/found couple, here's few examples:

But my main issue is really the movie not being moved if the thumbnail can't be downloaded. Part of me thinking it could be due to the sort.metadata.nfo.preferactressalias option I enabled to keep my actress metadata more uniform. I tested it further, the issue is not with the sort.metadata.nfo.preferactressalias

seeyabye commented 1 year ago

What scrapers are you using? ABP-755 should only return one actress for r18 and dmmja at least on my end.

ghost commented 1 year ago

When I made the post I had tried different things and even with only R18dev enabled. But currently I have these ones as it basically didn't end up mattering which I had on or off for this issue kuva I double-checked this with just the R18dev enabled and still ran into the issue.

I'm not sure if my sort settings are any help but here they are anyway: kuva

seeyabye commented 1 year ago

Could you also share what you have for the metadata priorities (especially for Actress).

ghost commented 1 year ago

Sure thing. kuva

Here is the rest too if you need them kuva

seeyabye commented 1 year ago

Thanks for providing the requested information.

In the future, it would be better to share the entire jvSettings.json instead of images. You can access it by clicking on 'JSON' under the Settings tab.

So apparently you had scraper.option.addmaleactors checked.

All I can say is that don't scrape for male actors for now. If you must insist on scraping for male actors, I recommend clearing out the jvThumbs.csv for male actors (deleting these lines for now). It seems like when male actors scraping was initially added, the images were hardcoded and stored in jvThumbs.csv, but most of the male actors thumbnail links are broken at this time.

I am still not sure what to do, so I will leave this issue open for now.

ghost commented 1 year ago

Aah I see, that's the reason then. Yeah, I'm not too fussed about knowing the male actors. Just trying to avoid ones with Bokki Sugiura

I think best solution would be just to have the male actor scraping but without the thumbnails so the feature keeps working at least.

seeyabye commented 1 year ago

From 2.5.17, Javinizer will ignore thumbnails with invalid links. It will continue to work (the nfos will have the actors/actress info), but the thumbnails for failed actors/actresses will not be downloaded.

ghost commented 1 year ago

Thank you for this update. It seems to work as it should now