search

javitu / rt-n56u

Automatically exported from code.google.com/p/rt-n56u
0 stars 2 forks source link

Commit 90c02bc26ba5c69b17a186c8493063d19f7506f8 breaks kernel 3.4 #1325

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
As the title says, kernel 3.4 will not compile with this commit in the tree.

Using GCC 4.8.3

Error:
net/core/dev.c:2642:6: error: static declaration of 'skb_flow_dissect' follows 
non-static declaration
 bool skb_flow_dissect(const struct sk_buff *skb, struct flow_keys *flow)
      ^
In file included from net/core/dev.c:143:0:
include/net/flow_keys.h:16:13: note: previous declaration of 'skb_flow_dissect' 
was here
 extern bool skb_flow_dissect(const struct sk_buff *skb, struct flow_keys *flow);
             ^
net/core/dev.c: In function 'skb_flow_dissect':
net/core/dev.c:2647:2: warning: ISO C90 forbids mixed declarations and code 
[-Wdeclaration-after-statement]
  int poff, nhoff = skb_network_offset(skb);

Original issue reported on code.google.com by moonman...@gmail.com on 1 Sep 2014 at 12:08

GoogleCodeExporter commented 9 years ago 
Reverting commit 90c02bc26ba5c69b17a186c8493063d19f7506f8 allows to compile.
I also tried adding "static" in function definition in flow_keys.h but it came 
up with another similar error, but now in some nfs module, so it can't be 
easily changed.

Original comment by moonman...@gmail.com on 1 Sep 2014 at 12:30

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
GCC 4.6.3 produced the same warnings:
net/core/dev.c: In function 'skb_flow_dissect':
net/core/dev.c:2647: warning: ISO C90 forbids mixed declarations and code

but the kernel was built.

Original comment by serge...@gmail.com on 1 Sep 2014 at 2:04

GoogleCodeExporter commented 9 years ago 
Don't know where you got 4.6.3 as it is not included in the sources, but Mr. 
Padavan already fixed it: 
https://code.google.com/p/rt-n56u/source/diff?spec=svnf9a5a378409c4bf9457611521e
31f5eda69f4a01&r=f9a5a378409c4bf9457611521e31f5eda69f4a01&format=side&path=/trun
k/linux-3.4.x/net/core/dev.c

Thanks Andy.

Original comment by moonman...@gmail.com on 2 Sep 2014 at 4:01