search

javivelasco / react-css-themr

Easy theming and composition for CSS Modules.
MIT License
591 stars 68 forks source link

Warning on console when using react v16.4 #94

Open rishichawda opened 5 years ago

rishichawda commented 5 years ago

When used with react v16.4, it throws an error in dev console which was introduced after v16.3 in support of removing the componentWillMount, componentWillReceiveProps, and componentWillUpdate lifecycle methods.

Since themr.js uses the componentWillRecieveProps lifecycle method, when used in a project with react v16.4, it throws a console warning. Moreover, this method will be deprecated in future releases of React ( v17.0 )

More about this here.

ovaldi commented 5 years ago

@rishichawda this repo is no longer maintained for 1+ year, now we use https://github.com/FriendsOfReactJS/react-css-themr

Please upgrade to the new version.

rishichawda commented 5 years ago

@ovaldi The same problem persists with the https://github.com/FriendsOfReactJS/react-css-themr fork. Should I raise the PR there?

Update : I've raised a pull request on the maintained fork. Hope that gets merged soon. Thanks @ovaldi for letting me know. Link to PR

ovaldi commented 5 years ago

@rishichawda Cool!

markusguenther commented 5 years ago

Problem has been solved in the fork ;)