search

javl / image2cpp

GNU General Public License v3.0
537 stars 160 forks source link

Support RGB 565 and mask bitmaps #27

Closed jochenderwae closed 4 years ago

jochenderwae commented 4 years ago

I added code to create 16 bit color bitmaps and bitmasks (1 bit alpha) for use with the Adafruit GFX library (drawRGBBitmap).

Changes include adding two conversion methods from pixel data to hex strings and UI options to select these methods and allow for an alpha background when rendering the image.

javl commented 4 years ago

I'm traveling at the moment and will need some time to check. Feel free to remind me of this pull request if I'm taking too long!

jochenderwae commented 4 years ago

Sure. I'll give you a nudge in two weeks.

Safe travels!

jochenderwae commented 4 years ago

Dear Jasper,

Just to remind you about this pull request

yt, Jochen

javl commented 4 years ago

Checking the code now. As I don't have the type of display you've made changes for I'll just trust those parts work.

As a general note: it's good practice to squash your commits before making a pull request, especially when you have made changes in one of the first commits that you revert or change again in later commits. This will prevent maintainers from having to check some changes, only to see they've been removed further down the stream of commits.

Example on Stack Overflow

jochenderwae commented 4 years ago

Thanks for the tip!

javl commented 4 years ago

@jochenderwae Thank you for the update. I took the liberty of adding your name + link to your profile to the credits in the readme. Hope that's OK.

jochenderwae commented 4 years ago

yeah, I saw it. That's ok.

Thanks (-: