search

javoire / dyslexia-friendly

Google Chrome extension that increases readability for people with dyslexia
https://chrome.google.com/webstore/detail/dyslexia-friendly/miepjgfkkommhllbbjaedffcpkncboeo?hl=en
GNU Affero General Public License v3.0
9 stars 2 forks source link

Ruler makes links unclickable on some pages #18

Closed selfthinker closed 5 years ago

selfthinker commented 5 years ago

The ruler makes links unclickable on some pages because it overlaps the text and links closer to where the pointer is. Example site where this is happening: https://alphagov.github.io/accessibility-personas/simone/

I suspect this happens because the ruler height is set in em while the top position is set in px. I have fixed this locally by adding a max-height: 20px; but the better fix would be to make the JS for the top position aware of the em size and reposition itself accordingly. Or make the ruler height use px. Although that would mean it wouldn't fit the height of the text correctly, you could also re-calculate the em into px to fix that.

selfthinker commented 5 years ago

I will deploy a hack to fix this on that example site next week, so you won't experience it happening there after that. Unless you temporarily disable that hack via the browser's inspector.

javoire commented 5 years ago

Hi, thanks for your feedback! That's indeed a silly bug, thx for finding it, I made a fix here https://github.com/javoire/dyslexia-friendly/pull/19, hoping to ship it in a few days.

Cheers!

javoire commented 5 years ago

fixed at https://github.com/javoire/dyslexia-friendly/blob/master/src/css/contentscript.css#L79

A new version has been released in Chrome Web Store