search

javrasya / django-river

Django workflow library that supports on the fly changes ⛵
BSD 3-Clause "New" or "Revised" License
742 stars 105 forks source link

Warnings when using Django 1.8 #10

Closed george-silva closed 9 years ago

george-silva commented 9 years ago

Hello guys,

Cool project! I'm just testing this and it seems that there are a bunch of warnings here related to the deprecation of explicit label apps. I'm not sure why this is happening, but I'm using also django-tenants and I'm treating this as a tenant app (I'll get the same models that we have on river for each schema, each schema corresponding to a single customer).

/home/george/projetos/.virtualenvs/greentape/local/lib/python2.7/site-packages/river/models/proceeding.py:28: RemovedInDjango19Warning: Model class river.models.proceeding.Proceeding doesn't declare an explicit app_label and either isn't in an application in INSTALLED_APPS or else was imported before its application was loaded. This will no longer be supported in Django 1.9.
  class Proceeding(BaseModel):

Not sure if this is only me, or if it's in general.

javrasya commented 9 years ago

Yeah. I have saw that warning for a long time. I didn't care about it :-) . But it seems that it bothers. Actually it will really be bothering when Django 1.9 is released. So, It'll be fixed in next version. After my commit about it, you can also use github master brach to pip install. Thank you for reporting.

george-silva commented 9 years ago

:clap:

george-silva commented 9 years ago

@javrasya still getting the warnings. Current version: 0.5.2

/home/george/projetos/.virtualenvs/greentape/local/lib/python2.7/site-packages/django/contrib/auth/models.py:98: RemovedInDjango19Warning: Model class django.contrib.auth.models.Group doesn't declare an explicit app_label and either isn't in an application in INSTALLED_APPS or else was imported before its application was loaded. This will no longer be supported in Django 1.9.
  class Group(models.Model):

/home/george/projetos/.virtualenvs/greentape/local/lib/python2.7/site-packages/django/contrib/auth/models.py:436: RemovedInDjango19Warning: Model class django.contrib.auth.models.User doesn't declare an explicit app_label and either isn't in an application in INSTALLED_APPS or else was imported before its application was loaded. This will no longer be supported in Django 1.9.
  class User(AbstractUser):
javrasya commented 9 years ago

These are models in Django itself. I am sure that they are gonna fix it with release 1.9 :-)