search

javrasya / django-river

Django workflow library that supports on the fly changes ⛵
BSD 3-Clause "New" or "Revised" License
741 stars 105 forks source link

🔥 Drop support for Django 1.11, 2.0, 2.1 #183

Closed simkimsia closed 3 years ago

simkimsia commented 3 years ago

Also bumped up the python support to include python 3.7, 3.8 and 3.9

closed #181 closed #182 closed #179

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 81.646% when pulling 7dd8362f5dd477ccc457adb37f8b6dbb6b8a66ee on simkimsia:drop-unsupported-django into 06a23df4856beb594aa5734e0fb888a2a1fc4a75 on javrasya:master.

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-81.6%) to 0.0% when pulling 2a3a0adcdf41b91b66dfb0f5d46bd9da56619b4a on simkimsia:drop-unsupported-django into 06a23df4856beb594aa5734e0fb888a2a1fc4a75 on javrasya:master.

simkimsia commented 3 years ago

@javrasya Please review this PR thank you

javrasya commented 3 years ago

Hi @simkimsia. Great job. It is looking good. Can you update README file as well regarding which python and Django version it supports from now on?

simkimsia commented 3 years ago

@javrasya image

Is this okay?

javrasya commented 3 years ago

Absolutely, go for it 👍

simkimsia commented 3 years ago

Absolutely, go for it 👍

pushed. only change is README.rst. feel free to merge

simkimsia commented 3 years ago

@javrasya There's a new beta for discussions by github https://docs.github.com/pt/free-pro-team@latest/discussions. After this PR is merged, my next step is to try to use river in a side project. So I may have more follow up questions on usage. Instead of flooding issues with [Question] maybe you want to turn on the discussions feature instead. That way, I can ask questions more freely

javrasya commented 3 years ago

@javrasya

There's a new beta for discussions by github https://docs.github.com/pt/free-pro-team@latest/discussions. After this PR is merged, my next step is to try to use river in a side project. So I may have more follow up questions on usage. Instead of flooding issues with [Question] maybe you want to turn on the discussions feature instead. That way, I can ask questions more freely

Didn't know there was such a thing. Let me check and turn it on.

I will make a new release out the changes you have made but you don't need to wait for it since the latest available version is proven that it already supports newer version of Python and Django except that it was only not tested.

simkimsia commented 3 years ago

you don't need to wait for it

Oh I'm not purposely waiting for it. I know it should work. It's just my own rhythm. I like to do a nice complete atomic work unit per day or every 2-3 days on this topic on workflow.

Upgrading the Django and python on this library is the nicely complete work unit for today 🙌

javrasya commented 3 years ago

I enabled the Discussions with the repo. Thank you for the info @simkimsia . It has been very good to have a space for discussions 😊

simkimsia commented 3 years ago

Thank you for the info

welcome. You can start moving some of the questions under issues over there, I think. I also hate to see the Issues tab polluted with non bug reports.