search

javrasya / django-river

Django workflow library that supports on the fly changes ⛵
BSD 3-Clause "New" or "Revised" License
742 stars 105 forks source link

Will you consider adding pre-commit to help enforce syntax and formatting standards? #189

Open simkimsia opened 3 years ago

simkimsia commented 3 years ago

Hi @javrasya

I have been thinking for a while when I last contributed a PR and I noticed you had to solve my formatting issues.

I now have a python/django coach (Adam Johnson) and he recommended me that he used pre-commit https://pre-commit.com/#install as way he enforced standard formatting issues for all his open source libraries.

I have been experimenting pre-commit for my own private django sideprojects and I think it's really helpful.

Of course, he advised me to check with the maintainer of the open source I contribute to if they are open and basically it's up to them. I agree.

What do you think?

javrasya commented 3 years ago

Hi @simkimsia , that sounds like a great idea. To be honest I haven't known about this. So let me have a look at it.

simkimsia commented 3 years ago

Let me know I think I prefer to contribute after u have a precommit settings