search

javserlah / qforce

QForce
0 stars 0 forks source link

nl.qnh.qforce.domain.Gender has been changed #5

Open marceloverdijk opened 6 years ago

marceloverdijk commented 6 years ago

Despite explicitly stated in https://github.com/Q24/qforce/blob/master/README.md

The project should use the nl.qnh.qforce.domain and nl.qnh.qforce.service interfaces. Implementations must be developed and these interfaces may not be changed.

the nl.qnh.qforce.domain.Gender class has been changed.

javserlah commented 6 years ago

I thought it was written to not change only the explicit interfaces. Gender being an enum I thought it could be changed.

marceloverdijk commented 6 years ago

No we don’t want to have it changed to see how you would cope with it. We don’t want to use Json annotations in the model classes to separate concerns.

Would you be able to change this back again to the original code?