javserlah / qforce

QForce
0 stars 0 forks source link

What code style rules are used? #6

Closed marceloverdijk closed 6 years ago

marceloverdijk commented 6 years ago

Did you use any code style rules?

E.g. we see:

https://github.com/javserlah/qforce/blob/4f75e51011e43ba3d84e3c04ad4fe240e200952d/src/main/java/nl/qnh/qforce/controller/QForceController.java#L45

return person.isPresent()?ResponseEntity.ok().body(person.get()):new ResponseEntity<>(HttpStatus.NOT_FOUND);

as one liner without any spaces is very difficult to read.

javserlah commented 6 years ago

Yes, i always try to be clean when writing code because is really important to understand the code if someone else reads it afterwards. In this case I just tried to make a quick response just for returning both status.

marceloverdijk commented 6 years ago

OK.