javsezlol1 / Stylez

111 stars 8 forks source link

Updates keep reverting config.json #17

Closed ManOrMonster closed 10 months ago

ManOrMonster commented 10 months ago

When this updates, config.json changes "autoconvert" to "true" which converts all my styles again. I think this is happening due to all the branch renaming or creation or whatever has been going on the last couple of weeks.

It also deletes my favorites.

I don't want to autoconvert again, it errors out and then I have to update the config again and restart the UI. And of course I don't want my favorites gone.

I'm once again requesting that autoconvert be made into an optional button or something so this stops firing whenever a new update is made. It really shouldn't be in a config file. It should be something people can run at will.

And no one should ever lose their favorites.

Also, any changes made to existing stylez get overwritten. My Terry O'Neill style has a custom image which keeps getting overwritten.

javsezlol1 commented 10 months ago

Sorry this shouldn't be happening I keep adding the configs file to the ignore list and it keeps committing it! Sorry for the inconvenience, I may make the config file generate from code if this keeps happening the only thing that should change is the updated files not the config file or as suggested by the one of the automatic devs is move the options to shared.opts

I think my github need changing to only pull changed files/ updated not all files

On Thu, Nov 2, 2023, 5:21 AM ManOrMonster @.***> wrote:

When this updates, config.json changes "autoconvert" to "true" which converts all my styles again.

It also deletes my favorites.

I don't want to autoconvert again, it errors out and then I have to update the config again and restart the UI. And of course I don't want my favorites gone.

I'm once again requesting that autoconvert be made into an optional button or something so this stops firing whenever a new update is made. It really shouldn't be in a config file. It should be something people can run at will.

And no one should ever lose their favorites.

Also, any changes made to existing stylez get overwritten. My Terry O'Neill style has a custom image which keeps getting overwritten.

— Reply to this email directly, view it on GitHub https://github.com/javsezlol1/Stylez/issues/17, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWX5VGYSAIHPWRIPYZTSWS3YCK4MTAVCNFSM6AAAAAA6Z45RY6VHI2DSMVQWIX3LMV43ASLTON2WKOZRHE3TGMJTGEZDGNY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

javsezlol1 commented 10 months ago

Fixed it. Creates the config file instead of downloading it shouldn't have any issue now, sorry about that

For the overwriting of styles I'll have to see what I can do there user edit shouldn't get overwritten

javsezlol1 commented 10 months ago

It looks like there's no way for get hub to not overwrite the images.. Gitignore doesn't work the way I thought it did which explains alot. It looks like the only way is to make a separate repo containing all the styles and have sylez download that repo which sucks because I cannot expand on it without doing some weird work around.....

ManOrMonster commented 10 months ago

Good to know. Thanks for the fix