Pagination false doesn't hide pagination

javve / list.js

The perfect library for adding search, sort, filters and flexibility to tables, lists and various HTML elements. Built to be invisible and work on existing HTML.

https://listjs.com

MIT License

11.2k stars 896 forks source link

Pagination false doesn't hide pagination #741

Open ABooooo opened 3 years ago

ABooooo commented 3 years ago

Hi, if I set pagination to false I still see the pagination menu under the list. I also tried it in your codepen. If one changes value to false nothing happens. Am I understanding/using this wrong or is it a bug? Thank you

ABooooo commented 3 years ago

Can someone please replay to this and check out if this really is a bug? Thanks!

if (options.pagination[0] === undefined) { - row 257, I guess [0] shouldn't be there

dragonstyle commented 2 years ago

I can reproduce on the codepen as well...

jrcreative commented 1 year ago

I found this as well. Instead of setting pagination to false set it to undefined and you'll get the desired result.