search

jawa-the-hutt / nativescript-vue-shadow

MIT License
15 stars 7 forks source link

add ns 7.0 compatibility #7

Open Upd4ting opened 4 years ago

Upd4ting commented 4 years ago

feel free to review and accept it

micc83 commented 3 years ago

@Upd4ting Thank you very much, your PR works like a charm (at least on Android, didn't try on iOs). Hopefully it will be merged soon.

eaglejs commented 3 years ago

Any movement on this? Or is this plugin abandoned?

Upd4ting commented 3 years ago

@eaglejs seems abandoned but you can use this npm package if you need the ns-7 version https://www.npmjs.com/package/nativescript-vue-shadow-ns-7

eaglejs commented 3 years ago

Thank you @Upd4ting! Since my app is Android only, I ended up just using the androidElevation attribute/css property. You can put it on any NS defined element. I decided to put it on a class .card in my css file.

.card { background-color: #fff; android-elevation: 5; } alternatively, you can put it on the element as an attribute <StackLayout androidElevation="5"></StackLayout>

That gave me the shadows back, only downside is that it does not work on iOS. And you do need a background-color defined.

jawa-the-hutt commented 3 years ago

Hey all. Sorry for not responding up to this point. Been trying to figure out a way to do this and make sure everything works. However, I created this plugin over a year ago, and have since lost access to a Mac to be able to do any further development and validation that things are working.

I'm not actually using Nativescript on anything at the moment due to a job change so that's another issue I have with trying to maintain this. With those two things together, I just haven't done anything with this PR and I apologize for that. It's not fair to all of you who use it.

I can go ahead and merge this PR without testing it, but not sure when I will be able to get npm updated. You can still install directly from Github but I know that's a pain.

So, the choices are:

  1. Let this repo and plugin die and everyone use the new fork.
  2. Merge the PR and hope it works for everyone and if it doesn't, then there may not be any further updates.
  3. Allow someone else in the community the ability to manage the repo and npm package.
  4. Turn the repo and npm over to someone who wants to maintain it going forward.

Looking for feedback on this.

Upd4ting commented 3 years ago

Hello @jawa-the-hutt

No worries, thanks for your answer! If you need help, I can maintain this for you.