jawah / charset_normalizer

Truly universal encoding detector in pure Python
https://charset-normalizer.readthedocs.io/en/latest/
MIT License
562 stars 51 forks source link

[Proposal] Vendoring charset-normalizer in pip #456

Closed bluetech closed 4 months ago

bluetech commented 4 months ago

While looking into pip's startup time, I found that replacing chardet with charset-normalizer improves things. pip has a policy of vendoring its dependencies, so I'd like to propose to pip to change its vendoring from chardet to charset-normalizer.

Before I do it, I'd like to ask if you are OK with this?

See pip discussion here: https://github.com/pypa/pip/issues/4768#issuecomment-2062541405

Ousret commented 4 months ago

I am OK with this.

While speaking performances, maybe in a not too distant future, pip may consider replacing requests for niquests.

Regards,

notatallshaw commented 4 months ago

pip may consider replacing requests for niquests

I'm not a pip maintainer, but pip generally requires having pure Python dependencies only, taking a quick look at niquests dependencies I see qh3 requires compiling some C code, this wouldn't at the moment fit pip's distribution model.

Ousret commented 4 months ago

qh3 is optional.

notatallshaw commented 4 months ago

Well, someone would need to submit a proposal/PR and it would need to be considered by pip maintainers.

But, fyi, pip's resources are very low at the moment so maintainers are very cautious about changes that could cause breakage/support issues.