search

jawainc / simplecontact

Contact Us plugin for October CMS
6 stars 13 forks source link

Remove Translate requirement #36

Open vojtasvoboda opened 7 years ago

vojtasvoboda commented 7 years ago

This plugin can be used also at sites without more localisations, so plugin should not depend on Translate, am I right?

Maybe you can define function trans somehow like that?

if (!function_exists('trans')) {
    function trans($s) {
        return $s;
    }
}
jawainc commented 7 years ago

Many users have difficulty in translating, so i decide to use translate dependency

vojtasvoboda commented 7 years ago

Yes translating is great idea. But what if I have a website only with one locale? I don't want to download another plugin for Translations.

jawainc commented 7 years ago

People have contributed for languages, so they want it to be more global not just targeting one language. right ?

vojtasvoboda commented 7 years ago

Yes I know. Translations are great. But your plugin CAN work without Translate plugin. Just try it. I've tried it now and it works great.

Just remove this line: https://github.com/jawainc/simplecontact/blob/master/Plugin.php#L22

So peoples with one-language sites don't have to download Translate plugin for nothing.

jawainc commented 7 years ago

ok, i'll do it on coming weekend