search

jawee / language-blade

Blade (Laravel) templating support in Atom
https://atom.io/packages/language-blade
Other
51 stars 21 forks source link

Inline "@yield" cause syntax highlight error #69

Closed cytsunny closed 7 years ago

cytsunny commented 7 years ago

image

The syntax is okay when separated into lines. However, when in oneline:

image

Ingramz commented 7 years ago

It has to do with greedy parenthesis matching that has been explained in https://github.com/jawee/language-blade/issues/33#issuecomment-172063712. All blade directives currently behave in a similar manner.

Ingramz commented 7 years ago

@cytsunny I just released v0.31.0, please verify whether the issues you were having have now been solved.

cytsunny commented 7 years ago

Yes, the problem is solved. Thanks for the update.

cytsunny commented 7 years ago

But I wonder how you solve the problem now? Isn't the problem caused by language-php package?

Ingramz commented 7 years ago

@cytsunny currently Blade grammar is a modified PHP grammar from language-php package and does not depend on you having a language-php package installed. This is due to an issue where PHP grammar cannot be currently included in other grammars, so we need to have a copy of it in the same file.

Every time I do commits like https://github.com/jawee/language-blade/commit/dca736cf8903c4739e7ace6662ddcd036883a781, I simply take what's available on language-php repository and just apply the changes here.

Of course following that commit on this repository are changes required to accommodate the changes from language-php, but these are rather trivial compared to what was done in the PHP grammar.