jawi
commented
10 years ago Thanks for your contribution. While I do see a need for easier manipulation of the triggers, I'm not entirely convinced about your proposed solution. Allow me to explain: as far as I can tell from your patch, you can only manipulate a single trigger stage, which is, IMO, not covering all the use cases I'd like to cover. In the easiest case, the OBLS allows you to build a four-stage state machine as trigger. With the HP165xx-style triggers this state machine can become even more complex. Having thought about this, I'd propose to make the trigger-configuration and editor part of the main UI. Something akin to the views that already are present aside the main waveform view. I think this could cover two use cases: 1) see how the acquired data is obtained by the current trigger configuration, and 2) allow tinkering with the trigger settings for succeeding acquisitions. What do you think?
Zizzle
A bit of a hack, you can still see some magic numbers sprinkled, but from my last pull request I know you like to rewrite these things anyway :)
So the idea is that when debugging some hw you want to easily adjust triggers and recapture with as few clicks as possible. Of course the trade off is with screen space. You could potentially have off,high,low trigger buttons for each channel.
With this implementation there is a small display on each channel label that cycles as you click.
We may also want to consider adding transition triggers using more than just the first trigger stage.