oms not working for AdvancedMarkerElement

[umeWaheed]

Google maps recently deprecated Marker and introduced AdvancedMarkerElement. Using spiderfier for this new marker throws exceptions for the following methods:

• getVisible
• getPosition
• getZIndex
• setPosition
• setZIndex

[ericberman]

Yes, please address! I've found no other good solutions. Shame on Google for deprecating Marker and breaking this with the "upgrade"

[umeWaheed]

Thanks for reviewing the issue. Do I need push access to the repo, as I've been getting permission denied error.

On Mon, 4 Mar 2024, 06:43 Eric Berman, @.***> wrote:

Yes, please address! I've found no other good solutions. Shame on Google for deprecating Marker and breaking this with the "upgrade"

— Reply to this email directly, view it on GitHub https://github.com/jawj/OverlappingMarkerSpiderfier/issues/180#issuecomment-1975508030, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFJYR4QDOO2LXHCFUBBQAE3YWPGU5AVCNFSM6AAAAABEBPVSI2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZVGUYDQMBTGA . You are receiving this because you authored the thread.Message ID: @.***>

[ericberman]

I was just upvoting the issue; I'm not familiar enough with coffee to be able to make the fix myself. @jawj - I'm hoping you can provide guidance if not a fix!

[ericberman]

I may have a fix for this. Testing right now.

[ericberman]

Pull request submitted

[remcokalf]

Upvote, we are also waiting on this, before we can move our Maps implementation to Advanced Markers.

[ericberman]

Want me to send you what I have so you can test it?

[remcokalf]

Thanks you for the offer. But as things stand now, we prefer to include the library as a whole, not a fork or a customized version. Unless this is not going to be fixed by the maintainers of course. There are no info yet about when Google will actually drop legacy markers, but it will happen at some point, so I hope this gets fixed, rather sooner than later.

[copiri-six]

Given that the latest update to this repo was in January 2019, I assume that it is no longer maintained.

I have forked the code and updated it to work with AdvancedMarkerElement... if anyone wants the script, you can check out the repo here: https://github.com/copiri-six/AME_Spiderfier.

caveat emptor: I only did the bare minimum in my fork to get the code to work for me. Your mileage may vary... but feel free to contribute over there if you'd like to see further improvements.

[ericberman]

Nice - thanks!!!

[copiri-six]

And I should have said... thanks @ericberman for getting the work started, your commit mentioned above was 90% of the work required. Much appreciated!

[remcokalf]

This is great! thank you!

[jawj]

Sorry for the long silence here. I don't use this library myself any more, but I'll try to integrate these fixes soon.

[remcokalf]

@jawj that would be awesome! We're using it in FacetWP.com Google map integration, and we'd like to move to Advanced Markers.

[JoelLisenby]

Thanks all, we were just discussing this one within the last week and it's appreciated that you're upgrading it to advanced markers.

[dCogs]

This saved us a ton, thanks!

[jaydiazzz]

+1