jawknee / coLab

coLab Project
0 stars 0 forks source link

Align images to their purpose #61

Open jawknee opened 9 years ago

jawknee commented 9 years ago

The screenshot graphic is way overloaded - create a new "Graphic" image and have that be the one that's going to be displayed, then have screenshot and soundgraphic always display just that. Allow for screenshot to be "None" since one is not technically required.

Means allowing saving of a page with no screenshot - assuming there's a sound - and there needs to be. Also - reference this info from an email I sent myself a couple of weeks back…


With no Internet - this'll do for what I need to do to fix how graphics are handled - esp. the partial hang when creating a new page.

This could be tied in with the issue about how to create a page/song

Things that need to happen:

Currently I think all of the graphics will live in the page's coLab_local dir, except:

Need to add code to page generation to make the initial copies of graphics, a la

for (image, dest)  in [ ('PageSound', 'SoundImage.png?'), ('Screenshot', 'Screenshot.png?') ]:
    for type in [ '', '_tn' ]:
        "copy":   resource_path + 'coLab-No' + image + type + '.png' 
                    "to":        local_path/coLab_local + dest 

Also copy the php/page_index.php to local index.php

Trace through the code in imagemaker, esp. around thumbnail generation and try to keep the roles straight:

graphic: points to current file - for tool display screenshot: cropped graphic - with time/locator/sound info overlays soundgraphic: generated image from the sound, ditto

This will allow the option of saving a page but not generating it in case needed pieces are missing.

This also ties in with managing page generation: 1) allow an option to force or prevent page regeneration, 2) display if the page is: unchanged, altered, or pending a rebuild.

Might make sense to do things in this order: modify page creation to not create dir until saved, build the file name automagically from desc. Add option to display "graphic" to the right of the screenshot selector Add file copies to page creation (graphic_tn, php) Work through the code to correctly set up the images when creating a new page

jawknee commented 9 years ago

This is actually going to be bigger than I thought… I want the thumbnails out of coLab_local - at least for now - they're polluting the graphic "reuse" selection.

I think I need to add page versioning as well - start with version 0.0 for un-versioned pages and work up from there.