Closed apivovarov closed 3 weeks ago
Peter, Jake, whenever you have time, could you please review this pull request?
f8E4M3
support has already been merged to LLVM APFloat and MLIR.
I also need to add f8E4M3
to XLA. Internally XLA uses tsl which depends on ml_dtypes - tsl/platform/ml_dtypes.h
@hawkinsp @jakevdp
@apivovarov I'm on vacation this week, but I'll take a look next week. Sorry for the delay...
@apivovarov I'm on vacation this week, but I'll take a look next week. Sorry for the delay...
Hi Peter, it seems this PR got overlooked. @hawkinsp
BTW, I've also attached a link to the StableHLO [RFC] Add f8E4M3 and f8E3M4 types support https://github.com/openxla/stablehlo/pull/2486
Not sure what change should be merged first StableHLO or ml_dtypes.
The linter is also sad, please fix.
And it doesn't matter whether the stablehlo change or the ml_dtypes change is merged first, really, they aren't directly coupled.
Linter is still sad.
Linter is still sad.
Fixed. pre-commit run --all-files
- all green now
This PR adds
f8E4M3
type.f8E4M3
type follows IEEE 754 conventionRelated LLVM PRs:
RFCs:
Related ml_dtypes PRs:
C++ Testing
Tested as described in PR-123 Add CMakeLists for C++ tests