jaxbot / browserlink.vim

Live browser editing for Vim
MIT License
711 stars 38 forks source link

Fixes #38 #45

Closed elliotec closed 7 years ago

elliotec commented 8 years ago

Edit readme to add proper documentation on NPM dependencies to install.

jaxbot commented 8 years ago

But it comes bundled with a node_modules folder to prevent this, was this really required for you out of the box?

Also fs, http, and path should be bundled with Node, unless something has changed -- been out of the node loop lately

elliotec commented 8 years ago

Apologies. I am not also entirely in the Node loop, but I looked it up and those still should be bundled with node.

I was required to install websockets at the very least, and didn't notice the node_modules directory, but it seems that I'd have to do an npm install from there if I didn't globally install websockets anyway.

I've updated the PR for this, but let me know if it should be working a different way.

Strangehill commented 7 years ago

Having installed websocket, I still can't get browserlink to work. I tried running node browserlink.js before and after installing websocket, and this two-line warning disappeared.

Warning: Native modules not compiled.  XOR performance will be degraded.
Warning: Native modules not compiled.  UTF-8 validation disabled.

But the remainder of the error message didn't change:

events.js:182
      throw er; // Unhandled 'error' event
      ^

Error: listen EADDRINUSE :::9001
    at Object.exports._errnoException (util.js:1024:11)
    at exports._exceptionWithHostPort (util.js:1047:20)
    at Server.setupListenHandle [as _listen2] (net.js:1319:14)
    at listenInCluster (net.js:1367:12)
    at Server.listen (net.js:1467:7)
    at Object.<anonymous> (/Users/cog/.vim/bundle/browserlink.vim/browserlink/browserlink.js:75:8)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
elliotec commented 7 years ago

Oh, yeah, this thing doesn't work, never did.