Out of Box Experience - Githubissues

her commented 8 years ago

Hey Jonathan,

I added a package.json file to easily pull dependencies for browserlink.vim and made a small change to the readme to explain the additional installation step.

I love your app and it's been a lot of fun using!

Hope this adds to the out of box experience for other users 🙂 Let me know if you have anything I should add or do to make the PR the best it can be. Best wishes for a nice day 👋🏻

-Melanie

jaxbot commented 8 years ago

Sorry for taking so long to get back to you! Been a crazy month.

It looks good, but I'm wondering if we can just bundle up all the node_modules into this repo and check them in. It's dirty, but it allows people to just download the package or add it to Vundle/Plugvim/etc and have it work out of the box.

her commented 8 years ago

No big deal! I think I did the same responding to one your emails because, life. 😄

We could do that, definitely. We could leave the readme instructions with npm install in case our /node_modules/ is out of date, that command would update things.

If you want I can just add /node_modules/ to this PR, or you could merge this and then I'll submit another PR for /node_modules/. Also I noticed that in this PR I said I added /node_modules/ to .gitignore, looks like I goofed there(it's missing) so that wouldn't need any changes.

Otherwise, yeah! I think we're good. Bonus? /node_modules/ for this project is a whopping

236K

Watch out now 😉

Strangehill commented 7 years ago

i haven't succesfuly run browserlink yet, so I copied your package.json and installed. It's still failing though. The error I get is Cannot find module 'websocket'. I see your requiring 'websocketserver' instead of 'websocket', so I changed var WebSocketServer = require("websocket").server; to var WebSocketServer = require("websocketserver").server; but the new error says "TypeError: WebSocketServer is not a constructor", so I changed that to var WebSocketServer = require("websocketserver"); and that gets me a step further by returning

Creating Server...
Setting server send method to: all
Server started and listening for connections on port 8080

but, not so fast, cause that's followed by this error:

events.js:182
      throw er; // Unhandled 'error' event
      ^

Error: listen EADDRINUSE :::9001
    at Object.exports._errnoException (util.js:1024:11)
    at exports._exceptionWithHostPort (util.js:1047:20)
    at Server.setupListenHandle [as _listen2] (net.js:1319:14)
    at listenInCluster (net.js:1367:12)
    at Server.listen (net.js:1467:7)
    at Object.<anonymous> (/Users/cog/.vim/bundle/browserlink.vim/browserlink/browserlink.js:75:8)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)

which is pretty much the same error I was getting before I even first tried npm install.

jaxbot / browserlink.vim

Out of Box Experience #46