search

jaxbot / github-issues.vim

Github issue lookup in Vim
http://jaxbot.me/articles/github-issues-vim-plugin-5-7-2014
Other
405 stars 28 forks source link

Label colors do not work in terminal #128

Closed cj closed 9 years ago

cj commented 9 years ago

I'm using the latest version of github-issues and neovim.

jaxbot commented 9 years ago

I'm not sure how Neovim handles colors; Gissues only supports the rgb format of colors, so colors do not work in the terminal. Any documentation on this?

cj commented 9 years ago

@jaxbot ah that will be why, I'm using neovim in the terminal. I'd probably have the same issue with regular vim. This might be a project worth looking at to help add support for term colors https://github.com/stephencelis/ghi

p.s. sorry for the late response.

jaxbot commented 9 years ago

Think I'll end up mapping GitHub's rgb values to the closest equivalent xterm value...

jaxbot commented 9 years ago

Alright, seem to have it more or less working. It requires the terminal to be set to xterm_256colors, but it seems to work on my machine.

cj commented 9 years ago

Awesome! I seem to be getting this error http://i.imgur.com/garFET0.png

jaxbot commented 9 years ago

Ah, so that error was thrown because of a bad assertion, which I just fixed on that branch. But the error occurred in the first place because your terminal isn't set to xterm_256colors. Can you tell me what the output of :echo &term is?

cj commented 9 years ago

@jaxbot ah there we go. Works great now! :D Thank you for adding this!

jaxbot commented 9 years ago

No problem, thanks for reporting!