Disable Completion when No Network is Available

jaxbot / github-issues.vim

Github issue lookup in Vim

http://jaxbot.me/articles/github-issues-vim-plugin-5-7-2014

Other

405 stars 28 forks source link

Disable Completion when No Network is Available #133

Open jalcine opened 9 years ago

jalcine commented 9 years ago

This plugin is notorious for hanging up my committing sessions when I'm disconnected from a network. It throws an exception (uncaught somewhere in the stack) and causes Vim to assume that the file (.git/COMMIT_MSG) was already saved.

This is me eyeballing community interest as I'm working on a patch to catch this example. All in all, if it can't connect or find the repository in question, it should fail silently (or at least provide an option to fail silently).

jaxbot commented 9 years ago

I agree with this; often times my Vim lags because of net issues and autocomplete trying to populate. I added some timeout stuff a while ago but it didn't really help.

The async/threading feature will help, but it's not the most optimal feature.

I can make it fail silently, but I think the biggest problem is the lag. If you have a patch that makes it better in your case, though, please feel free to PR!