search

jaxbot / github-issues.vim

Github issue lookup in Vim
http://jaxbot.me/articles/github-issues-vim-plugin-5-7-2014
Other
405 stars 28 forks source link

Markdown headers stripped from issue body on save #134

Closed wireframe closed 9 years ago

wireframe commented 9 years ago

running :Gissues and editing a particular issue strips any markdown headers from within the body.

example issue pane:

Add user avatars

### Changelog
* Add carrierwave gem to manage file uploads

In this example, the ### Changelog markdown header will be stripped out of the issue on save.

jaxbot commented 9 years ago

This is by design; similar to a commit message, any line starting with # is treated as a comment. That being said, there's not a good reason for this design and it should probably be changed to just work the way you expect it

On Thu, Jan 22, 2015, 10:41 AM Ryan Sonnek notifications@github.com wrote:

running :Gissues and editing a particular issue strips any markdown headers from within the body.

example issue pane:

Title: avatars (9)

Reported By: wireframe

State: open

Labels: 2 - Working

Add user avatars

Changelog

  • Add carrierwave gem to manage file uploads

In this example, the ### Changelog markdown header will be stripped out of the issue on save.

— Reply to this email directly or view it on GitHub https://github.com/jaxbot/github-issues.vim/issues/134.

jaxbot commented 9 years ago

Updated it, how's this?

wireframe commented 9 years ago

I don't see any changes in the master branch of the repo to pull in? On Thu, Jan 22, 2015 at 8:58 PM Jonathan Warner notifications@github.com wrote:

Updated it, how's this?

— Reply to this email directly or view it on GitHub https://github.com/jaxbot/github-issues.vim/issues/134#issuecomment-71140465 .

jaxbot commented 9 years ago

Looks like the internet went down when I tried to push -- try now. Sorry about that

wireframe commented 9 years ago

:+1: local test looks good!

jaxbot commented 9 years ago

Glad to hear!