search

jaxbot / github-issues.vim

Github issue lookup in Vim
http://jaxbot.me/articles/github-issues-vim-plugin-5-7-2014
Other
406 stars 28 forks source link

...` etc.) and some messages (`referenced from 12345...`) has no `^M`. Why is it there? #136

Closed delphinus closed 9 years ago

delphinus commented 9 years ago

2015-01-27 20 54 14

vim: homebrew version => vim --version vimrc: here I'm using neobundle.vim

jaxbot commented 9 years ago

Sounds like the issue was written with Windows-style line endings, \r\n, which show up as ^M in Vim if the filetype is not set to Windows.

I think it's possible that GitHub is automatically adding these, so I'm not sure what to think. I might just strip them out automatically, since they aren't really necessary to be displayed in the editor.

delphinus commented 9 years ago

I also think it's good idea to strip ^Ms after fetching from github.

By the way, this plugin users except me do not see this strange chars? I see these chars in all issues.

delphinus commented 9 years ago

Ah, I tried to make issues from the browser and this plugin. The former issue contains ^M and the latter doesn't.

jaxbot commented 9 years ago

Testing

jaxbot commented 9 years ago

Alright, pushed a patch for that. Is the issue still occurring for you?

delphinus commented 9 years ago

Thx a lot! It seems to solve the existent problem on me.