jaxbot / github-issues.vim

Github issue lookup in Vim
http://jaxbot.me/articles/github-issues-vim-plugin-5-7-2014
Other
405 stars 28 forks source link

Error when viewing an issue #150

Closed meatcar closed 9 years ago

meatcar commented 9 years ago

Steps to recreate:

$ cd gitrepo
$ vim README.md

In vim, :Gissues hit ENTER on an issue, get the following error:

Error detected while processing function <SNR>34_showIssue..<SNR>34_setupOmni:
line    9:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "<string>", line 352, in populateOmniComplete
  File "<string>", line 365, in populateOmniCompleteFromDisk
IOError: [Errno 2] No such file or directory: '/home/meatcar/.vim/.gissue-cache/5887b4eefab83c3f382b22b9df3dd1a2a68fccf4a8250e94d874b434'
line   11:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "<string>", line 441, in doPopulateOmniComplete
  File "<string>", line 424, in grabCacheData
  File "<string>", line 393, in apiToDiskAsync
NameError: global name 'filehash' is not defined

I am running Arch, vim is compiled with --enable-pythoninterp --disable-python3interp.

meatcar commented 9 years ago

Seems like the two uses of filehash in autoload/ghissues.vim should be filepath. However, fixing that still throws the IOError. I have no settings set for this plugin in my .vimrc.

jaxbot commented 9 years ago

Some experimental code that was supposed to be behind a flag got executed. I'll have this fixed when I get home

On Mon, Jul 6, 2015 at 11:35 AM Denys Pavlov notifications@github.com wrote:

Seems like the two uses of filehash in autoload/ghissues.vim https://github.com/jaxbot/github-issues.vim/blob/6801c2442d874793ecb480bb9a5f9a224a89aa60/autoload/ghissues.vim#L397 should be filepath. However, fixing that still throws the IOError. I have no settings set for this plugin in my .vimrc.

— Reply to this email directly or view it on GitHub https://github.com/jaxbot/github-issues.vim/issues/150#issuecomment-118951687 .

jaxbot commented 9 years ago

Ah, I see what happened. vim.eval() will return a string, so saying if vim.eval("g:something"): will pretty much always pass. It should be fixed now, can you confirm?

Sorry about that!

meatcar commented 9 years ago

:+1: Works great. Thanks!