search

jaxbot / github-issues.vim

Github issue lookup in Vim
http://jaxbot.me/articles/github-issues-vim-plugin-5-7-2014
Other
405 stars 28 forks source link

Use Silent maps #158

Closed wsdjeg closed 7 years ago

wsdjeg commented 8 years ago

hi @jaxbot I think it is better use silent maps for the issue buffer,and some warning message should be hilight. thanks

wsdjeg commented 8 years ago

@jaxbot ping

jaxbot commented 8 years ago

Hey, sorry for the radio silence. Been trying to get my senior design projects done for graduation.

What are the pros/cons of this change?

wsdjeg commented 8 years ago
  1. use echom instead of echo to keep the message.even if there are more than one nessage output when vim startup.I will not miss this message.
  2. use silent map to make vim look clear.(this is just a suggstion,and I can use a g:var for it,let g:github_issue_UseSilentMaping =1) Note: but if use silent maping maybe the user do not know what he is doing.so maybe it should not be the default behavior.and I will give another commit later.