search

jaxbot / github-issues.vim

Github issue lookup in Vim
http://jaxbot.me/articles/github-issues-vim-plugin-5-7-2014
Other
405 stars 28 forks source link

BitBucket support #17

Closed jaxbot closed 9 years ago

jalcine commented 10 years ago

Is this something you're considering to (still) support?

jaxbot commented 10 years ago

If it can be implemented without obfuscating the whole thing, then sure. But I think if it'll add a lot of complication, it should probably be a fork

jalcine commented 10 years ago

I think it can be done with a tad bit of refactoring; it'd require an basis for pulling issues from any source.

Also, I have to ask; would you consider moving the Python code into a python folder? :shaved_ice:

jaxbot commented 10 years ago

Similar things were discussed before in #8, but I really would like to keep this plugin as simple as possible, such that I can show it to people who are new to Vim plugins and have it easy enough to dive into and read linearly.

That's why I'm hesitant to expand the feature set significantly; on the one hand, it would be totally awesome. On the other, it would be a nightmare to dive into. I guess I could just use an older version of the code as an example, though.

jalcine commented 10 years ago

Cool. However, the lack of splitting it would make this more of a 'hack' than a flexible, ornithological plugin.

jaxbot commented 10 years ago

Yeah, I think I'm starting to see the value in this. The plugin was originally a little light interface, but lately it's grown into a beast as it fits more and more workflows. It's probably best for it to do everything decently, than a couple of things indecently.

MaienM commented 10 years ago

What's the status of this? It sounds as if you are/were considering it, but that was half a year ago... Has any progress been made, is it still on the roadmap?

jaxbot commented 10 years ago

Dang, half a year. Surprising :o

I'm not 100% sure what the status of it is, honestly. I think it may be better to fork this project and implement the Bitbucket specific pieces, since the overall behavior of Bitbucket and Git are somewhat different. I also need to implement some support for Gitlab, so I'm torn between making small micro-projects for each, and making this one big solution for all. There are pros and cons to each, which is why this is marked as a question

MaienM commented 10 years ago

Yeah, it's not an easy decision... split it and you'll have a lot of duplicate code which is a royal pain in the ass, but leave it as one and you will risk having a lot of site-specific code messing up the big picture.

Still, I think that if you make an effort to split all site specific functionality into their own modules/classes, and just leaving the common parts (lots of the vim stuff probably) common, you can probably make that work, and I personally think it beats having duplicate code. If you set that up right the different sites would be completely split, so it is kinda like making micro projects.... but then bundled in one big project. Heh.

Anyway, that's what I'd go with.

jalcine commented 10 years ago

Would it be possible to abstract the common parts behind the issue trackers and then allow users to specify which ones they'd like to use for a particular project? On Aug 22, 2014 8:17 AM, "Michon van Dooren" notifications@github.com wrote:

Yeah, it's not an easy decision... split it and you'll have a lot of duplicate code which is a royal pain in the ass, but leave it as one and you will risk having a lot of site-specific code messing up the big picture.

Still, I think that if you make an effort to split all site specific functionality into their own modules/classes, and just leaving the common parts (lots of the vim stuff probably) common, you can probably make that work, and I personally think it beats having duplicate code. If you set that up right the different sites would be completely split, so it is kinda like making micro projects.... but then bundled in one big project. Heh.

Anyway, that's what I'd go with.

— Reply to this email directly or view it on GitHub https://github.com/jaxbot/github-issues.vim/issues/17#issuecomment-53053541 .

jaxbot commented 9 years ago

I've decided not to include Bitbucket support in this project. Anyone is welcome to fork the project and develop support for it elsewhere, and I apologize for not doing so myself or baking it into this repo. But the last few months have showed me that my priority list has too many things on it, and as someone who doesn't use Bitbucket for anything right now, I cannot justify building and maintaining support for it in this project. Sorry everyone.