search

jaxbot / github-issues.vim

Github issue lookup in Vim
http://jaxbot.me/articles/github-issues-vim-plugin-5-7-2014
Other
406 stars 28 forks source link

Add Python 3 support #57

Closed hluk closed 6 years ago

hluk commented 10 years ago

Tested with two Vim builds compiled with -python +python3 and +python -python3 (using Python 2.7.6 and Python 3.4).

Unfortunately Python code is no longer highlighted inside EOF section in plugin/githubissues.vim. Could be solved by using :pyfile.

blueyed commented 10 years ago

FWIW, the syntax highlighting in Vim is defined here: https://github.com/vim-jp/vim/blob/master/runtime/syntax/vim.vim#L656-L662

I could imagine that a patch for this would be accepted that also matches Python\w+ (and have just reached out to the maintainer via e-mail).

blueyed commented 10 years ago

btw: github-issues is the only plugin (besides YouCompleteMe) in my collection that insists on using python2.

blueyed commented 10 years ago

Apart from that, it would make sense to move the python code to a separate .py file, because it allows for better editing of the python code in general (code completion etc).

osleg commented 6 years ago

Merged in #172