Milestone support for issue creation

[sanmiguel]

I'd love to be able to assign an issue to a milestone when creating it.

Bonus points for omni-/neo-completion for milestone number (with text description of milestone name).

Possibly related to #31

[sanmiguel]

I've got a bit of time so I'm looking into this now. I don't appear to be able to assign it to myself, though.

[jaxbot]

Hm, yeah, looks like I can't do that either. Adding milestone omnicomplete and issue creation should be possible, but filtering by milestone as requested in #31 has to be done on the clientside.

[sanmiguel]

I don't think filtering client-side is the end of the world... I guess to do this properly we'd need to rig up something like getIssueList to load the milestone list into memory?

[jaxbot]

It should be easy enough to just check the milestone status during the getIssueList loop. I can look into that once I finish this homework assignment

[sanmiguel]

That'll work for existing issues, but for creating a new issue we'll need to know which milestones exist currently. I'll look at building that out now.

[jaxbot]

https://github.com/jaxbot/github-issues.vim/commit/6d4ad2a60923a02a69dafd01cf24caf860297ce2

[sanmiguel]

This last commit allows us to cache the milestone list. Now to add completion!

[sanmiguel]

Actually, first: I'll add the milestone field to the issue creation buffer

[sanmiguel]

3922780918b0a286a19270ab2f3689f00777b008

[sanmiguel]

That commit also includes a small fix for issue updates which seemed to be otherwise broken when noone is assigned to the issue.

[jaxbot]

See: https://github.com/jaxbot/github-issues.vim/tree/gh3.5

[jaxbot]

It's mostly implemented now, but I want to look into simplifying some of the code for the entire plugin in general, and it needs some testing before I merge it to master

[jaxbot]

Pushed some more changes. Looking good. Just needs more testing

[jaxbot]

Closing this, as it is implemented and seems to work