search

jaxbot / github-issues.vim

Github issue lookup in Vim
http://jaxbot.me/articles/github-issues-vim-plugin-5-7-2014
Other
406 stars 28 forks source link

GitHub API Token #91

Closed TrevorS closed 10 years ago

TrevorS commented 10 years ago

Hello Jonathan,

You suggest to users of github-issues.vim that they should add their GitHub API token to their .vimrc. This can be dangerous if the user commits their vim files to a public repository.

One option is to use a environment variable to hold the key they would like to use with your vim plugin.

Maybe there should be a warning in your documentation that reminds everyone that GitHub API tokens should be treated like passwords.

https://help.github.com/articles/creating-an-access-token-for-command-line-use

jaxbot commented 10 years ago

I suppose that would be an important note, but I figured it was a bit of a given. The same rule applies to environment variables, if people commit their bash/zsh/whatever config to public repositories, too. I've suggested to a few people that they source a local vim file with the variable set, which is how I do it, but I guess it's worth develing into more.

Thanks!