jaxbot / syntastic-react

React.js JSX support for Syntastic
93 stars 4 forks source link

Naming issue #1

Closed lcd047 closed 9 years ago

lcd047 commented 9 years ago

Hi, syntastic maintainer here. It would be great if you would configure your project to use its own script name, rather than overloading the script name of an existing project, and of one being phased out at that. Just saying.

jaxbot commented 9 years ago

Hello,

If you're interested in adding in a new script, I'd be happy to write one for this project. I wrote this one to override the behavior of JSXHint instead of adding a new script because I didn't want to add more code to the syntastic project when the JSXHint code would no longer be used. But if you'd be interested in a pull request, I'd be happy to write one up.

lcd047 commented 9 years ago

Not really. What I'm saying is, you now have conflicting names for essentially no reason. If your script would be called something else then the existing code in syntastic would support both jsxhintand your script without changes. You'd just have to point g:syntastic_javascript_jsxhint_exec to either jsxhint or your script, without needing to uninstall anything.

jaxbot commented 9 years ago

Ah, didn't know you could change exec names on the fly like that. That would make a better solution. I'll push out an update, thanks

On Wed, Feb 4, 2015, 7:32 AM LCD 047 notifications@github.com wrote:

Not really. What I'm saying is, you now have conflicting names for essentially no reason. If your script would be called something else the existing code in syntastic would support both jsxhintand your script without changes. You'd just have to point g:syntastic_javascript_jsxhint_exec to either jsxhint or your script without needing to uninstall anything, and without telling people they need to decide which one to keep.

— Reply to this email directly or view it on GitHub https://github.com/jaxbot/syntastic-react/issues/1#issuecomment-72846933 .

jaxbot commented 9 years ago

Pushed out an update to the package and README