search

jaxcore / bumblebee-hotword-node

BumbleBee Hotword for NodeJS
Apache License 2.0
13 stars 4 forks source link

Remove non-inherent dependency on Jaxcore #2

Closed benbucksch closed 4 years ago

benbucksch commented 4 years ago

BumbleBee node depends on jaxcore. Jaxcore is a large package, which itself again depends on many other packages. Actually, Jaxcore is not even declared as dependency in package.json, so it seems rather accidental.

But BumbleBee seems to need only the relatively small Jaxcore.Service class and a related class, and the logger.

I would recommend to break these dependencies into their own npm modules, and depend only on these. This would allow BumbleBee to be used in contexts outside of Jaxcore, which probably was the goal of the module.

dsteinman commented 4 years ago

I've just made these changes in the master branch. Please check and I'll publish 0.0.5 to npm.

benbucksch commented 4 years ago

Thank you!

Yes, I verified that 0.0.4 fails to run without jaxcore dependency, and 0.0.5 works without jaxcore dependency. VERIFIED FIXED.

Thanks! :)

dsteinman commented 4 years ago

Cool, I just published it.