search

jaxleyverse / jaxley

Differentiable neuron simulations with biophysical detail on CPU, GPU, or TPU.
https://jaxley.readthedocs.io
Apache License 2.0
46 stars 7 forks source link

Checked if the recodings are empty #460

Closed deezer257 closed 1 week ago

deezer257 commented 1 week ago

I inserted a check if the recording DataFrame is empty, if so I raised an value error. Nevertheless, I use a WSL and at some point the tests got stuck, at about 80% of completion, and the WSL lost connection.

Closes #365

deezer257 commented 1 week ago

Test is implemented.

michaeldeistler commented 1 week ago

Thanks! But the test is not a Python file. Please add the test to tests/test_record_and_stimulate.py and create a def test_empty_recordings() there.

michaeldeistler commented 1 week ago

Tests are not passing. You probably did not run black tests?

deezer257 commented 1 week ago

I only ran the specific test since all tests would take an hour to run. I will do it tomorrow, sorry!

michaeldeistler commented 1 week ago

Thanks again! black passes now, but the test you wrote now exists twice :D (You can always check changed files to see what you are trying to merge).

Could you delete the tests/test_empty_recording file?