search

jaxxstorm / action-install-gh-release

GitHub Action to install the Github Release binaries
Apache License 2.0
75 stars 32 forks source link

Make the tag input optional #27

Closed praneetloke closed 2 years ago

praneetloke commented 2 years ago

The tag input has a default value so it shouldn't be required.

praneetloke commented 2 years ago

The original motivation for opening this PR was that a GHA linter extension in VS Code was throwing an error because the input was not supplied despite it having a default value but coming to think of it more despite having a default value for the input, if a user passes an empty value accidentally through a variable, the required attribute would present a friendlier error message. Although I am not sure if GHA automatically uses the default value in such cases? I doubt they would, since the intention for the user was to use a value from a var. I didn't test that scenario and it doesn't apply to my use case. So I no longer think this PR adds any value.