jaxxstorm / action-install-gh-release

GitHub Action to install the Github Release binaries
Apache License 2.0
67 stars 29 forks source link

No files found after successful extraction #63

Open tmpfs opened 1 year ago

tmpfs commented 1 year ago

I am trying to install cargo-make from here.

This is my step:

      - name: Install cargo-make
        uses: jaxxstorm/action-install-gh-release@v1.10.0
        with:
          repo: sagiegurari/cargo-make
          platform: unknown-linux-gnu
          arch: x86_64

Here is the log output:

Run jaxxstorm/action-install-gh-release@v1.10.0
==> System reported platform: linux
==> Using platform: unknown-linux-gnu
==> System reported arch: x64
==> Using arch: x86_64
==> Using default file extension matching: .(tar.gz|zip)
==> Binaries will be located at: /opt/hostedtoolcache/sagiegurari/cargo-make/latest/unknown-linux-gnu-x86_64
searching for cargo-make-v0.36.12-aarch64-apple-darwin.zip with (unknown-linux-gnu|x86_64).*(unknown-linux-gnu|x86_64).*.(tar.gz|zip)
searching for cargo-make-v0.36.12-x86_64-apple-darwin.zip with (unknown-linux-gnu|x86_64).*(unknown-linux-gnu|x86_64).*.(tar.gz|zip)
searching for cargo-make-v0.36.12-x86_64-pc-windows-msvc.zip with (unknown-linux-gnu|x86_64).*(unknown-linux-gnu|x86_64).*.(tar.gz|zip)
searching for cargo-make-v0.36.12-x86_64-unknown-linux-gnu.zip with (unknown-linux-gnu|x86_64).*(unknown-linux-gnu|x86_64).*.(tar.gz|zip)
Downloading cargo-make from https://api.github.com/repos/sagiegurari/cargo-make/releases/assets/117691823
/usr/bin/unzip -o -q /home/runner/work/_temp/e2cd5860-2580-4835-8605-2f3db971730b
Automatically extracted release asset cargo-make-v0.36.12-x86_64-unknown-linux-gnu.zip to /opt/hostedtoolcache/sagiegurari/cargo-make/latest/unknown-linux-gnu-x86_64
Error: No files found in /opt/hostedtoolcache/sagiegurari/cargo-make/latest/unknown-linux-gnu-x86_64

However when I download the archive and extract manually the extracted folder name is cargo-make-v0.36.12-x86_64-unknown-linux-gnu which does not match the presumed installation location of unknown-linux-gnu-x86_64 - could this be the problem?

Would be great if this worked as expected, thanks 🙏

jaxxstorm commented 1 year ago

Yeah, unfortunately the directory structure of many archives makes it impossible to match every possibility. I'll happily take a PR to fix this