search

jaxxstorm / action-install-gh-release

GitHub Action to install the Github Release binaries
Apache License 2.0
67 stars 29 forks source link

Fix arm #65

Closed jwhitaker-swiftnav closed 1 year ago

jwhitaker-swiftnav commented 1 year ago

I think this should fix #61 :)

It's a bummer that github hosted runners don't offer arm.. :(

this works on an internal company project against golang-migrate though.

jwhitaker-swiftnav commented 1 year ago

ping @jaxxstorm

jaxxstorm commented 1 year ago

Is there any context on why this fixes arm builds? I'm happy to merge, but without a test or info about why this works I'm a little reluctant

jwhitaker-swiftnav commented 1 year ago

Ah sure, sorry - the return is a bug, it should be a break. The function still has a lot to do after switch statement here, so returning early skips all that remaining work that is needed. This should be clearly visible viewing the function as a whole, but github's diff view of a few lines doesn't really give enough context to see that. Cheers!