jaxxstorm / action-install-gh-release

GitHub Action to install the Github Release binaries
Apache License 2.0
75 stars 32 forks source link

feat: allow configurable project names #94

Closed t3hmrman closed 1 month ago

t3hmrman commented 1 month ago

This commit adds the ability to use configurable project names that are separate from the configured repo name (as in "/").

The main use case this feature enables is repositories that produce artifacts (possibly binary artifacts) which do not share the same name as the repository itself.

For example, project some-owner/some-repo may produce binary artifact abc-amd64-linux (--).


[!IMPORTANT] Add support for configurable project names separate from repository names, with updates to src/main.ts, .github/workflows/test.yml, and README.md.

  • Behavior:
    • Allow separate configuration of project name from repo name in src/main.ts.
    • Update asset matching logic to include project name in src/main.ts.
  • GitHub Actions:
    • Add example job wrpc in .github/workflows/test.yml demonstrating separate project and repo names.
  • Documentation:
    • Update README.md to include usage of project parameter for different artifact names.

This description was created by Ellipsis for 18451d2cb12c7a90c87c0e79aa5fc23dad70e72d. It will automatically update as commits are pushed.

jaxxstorm commented 1 month ago

Thank you @t3hmrman - this is an awesome contribution.

I'd like to make sure the project input isn't confusing, would it be possible to add an input called asset-name instead of repurposing the project variable?

t3hmrman commented 1 month ago

Hey @jaxxstorm asset-name is about a billion times better, thanks -- I'll make that change asap.

Will also look into the failing tests!

t3hmrman commented 1 month ago

OK, PR should be ready to go, all tests are passing on my fork and I've updated the docs! Would appreciate another review